Conversation
All Zorg's have been named properly
fix unnamed xtones blocks (zorg variants)
Ru lang some edits
remove packmode refs
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
* lang fixes and changes * qb text touchups * more touchups
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
* Create item_hiding.js * Update Korean translation * Update ko_kr.json * Update ko_kr.json
* Add recipe to copy flux_configurator nbt to flux items * Remove unnecessary event call --------- Co-authored-by: UltraPuPower1 <122467778+UltraPuPower@users.noreply.github.com>
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -10,4 +10,39 @@ ServerEvents.recipes((event) => { | |||
| .duration(2400) | |||
| .EUt(1024) | |||
| .circuit(1); | |||
|
|
|||
| @@ -10,4 +10,39 @@ ServerEvents.recipes((event) => { | |||
| .duration(2400) | |||
| .EUt(1024) | |||
| .circuit(1); | |||
|
|
|||
There was a problem hiding this comment.
🔴 Error prettier/prettier
Delete ····
Suggested change
| fluxItems.forEach((id) => { | ||
| event | ||
| .shapeless(Item.of(id), ['fluxnetworks:flux_configurator', id]) | ||
| .modifyResult((grid, result) => { |
There was a problem hiding this comment.
🟡 Warning no-unused-vars
'result' is defined but never used. Allowed unused args must match /^_/u.
|
|
||
| let data = fluxConfigurator.nbt.FluxConfig; | ||
| let newData = { | ||
| FluxData: { |
There was a problem hiding this comment.
🔴 Error id-match
Identifier 'FluxData' does not match the pattern '^$?([a-z][a-zA-Z0-9]|[A-Z][A-Z0-9](_[A-Z0-9]+)|$[A-Z][a-zA-Z0-9]|[a-z]|$)$'.
KubeJS Scripts Lint & Format ReviewFound 8 formatting issue(s) and 5 lint issue(s).
Detailed IssuesESLint Issues (5)
Prettier Formatting Issues (8)
|
* - add parallels to IAV - fix old casket in quest - fix prettier newline errors - fix shellite wire quest using converter template - chorus fruit compressor recipe conflict - fix RGM recipe conflict with strontium boosting - fix HAM and SPHC missing blocks in structure - fix gate multiblocks quest having a wrong dependency - fix mechanical sieve using tag instead of item - fix carbonic acid producing 3x potassium given - trim fat from processing lines - power chapter changes * fix network hub double tooltip * remove nuclear deprecation tooltip * fix kubes taking in dynamo hatches * fix CGS not allowing output hatches * readd new age config * create new age config * don't use alias * don't use aliases * nerf create steam engines by 25% * fix typo * Fix menu buttons and add FM editing tools * fix renaming issue * gcrop machine recipes and recipe type integration * fix recipes :/ * fix quest missing item, gas collector crash and toolkit missing removal * add better extended recipe builder types * fix compound generator preview * Update deionized_water.js * solar cell repair (disabled for now) * feedback * add minimum energy hatches for electric ore factory * Content: - Multiblock structure helper - Recipes for VM and GCROP - Fix assets issues for draconic neutron reflector - Recipe type stability for EGS - GCrops quest tree file (not in-game, very WIP) Co-authored-by: n1xx1 <n1xx1@users.noreply.github.com>, thanks for the help with typescript definitions * Content: - Final typescript fixes for multiblock tool - Recipe for stainless firebox - Steel buzzsaw in questbook * Thermal augments use build in modifiers instead of NBT * workable solar cell repair recipe * ts and eslint fixes * revert create engine nerf * A lot of fixes KubeJS - Large Kubes don't have fluid outputs - Molten destabiliser doesn't have fluid inputs - Add zalloy ABS recipe - Typos Quests: - Inaccurate dependencies for plasma turbine, wireless hub and EOF - Typos Configs: - Removed mentions of MA and addons - Blacklisted Sky Steel Block - Update configs for the following: - Craftpresence - Create new age - Create low heated - Fork - Core - Skyblockbuilder - Default world type * fix material issues at load up * undo added zalloy recipe * agh * fix warnings * hypertube recipes * fix formatting * remove redundant gitignore line add gcrops quest chapter * Add better dimensional stages implementation (#612) Revamp dimensional stages and coordinate crystals to look more visually appealing and remove 3 dependant mods * solar repair pt 1 * solar repair pt 2 * Circuit etching and lint fix * quest fixes * laserio gregification * modular routers gregification + fixes * test utility changes * programmatic item hiding for emi * add to eslint config * config updates * Remove electronicComponents from component_materials_type (redundant) * Revert "Remove electronicComponents from component_materials_type (redundant)" This reverts commit 0d10b21. * types: fixes * laserio fixes * fix some item hiding * add item hiding config back (removed vintage from config, less clutter) * blacklist cleaning * remove useless code and console warnings * fix menu helper, delete unnecessary gcrop chapter backup, change recipe helper zip function * simplify zip function * final mod and config updates * remove ae2 * fix laser io recipe issues * fix hypertubes recipes (pls test in game) + recipe dump utility * prioritize showing the dynamo hatches in the compound gen * fix pressing clay into brick requiring a block of clay * make network hub form in preview * fix laser IO recipes and update JEI configs --------- Co-authored-by: trulyno <78795220+trulyno@users.noreply.github.com> Co-authored-by: n1xx1 <me@simonemiraglia.it>
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
1 similar comment
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
All non `minecraft`/`gtceu`/`kubejs` items and methods now depend on their respective mods being loaded before they are used
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
1 similar comment
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
* Create zh_cn.json * Create zh_cn.json * Create zh_cn.json * Create zh_cn.json * Create zh_cn.json * Create zh_cn.json * Create zh_cn.json * Create zh_cn.json * Update zh_cn.json * Create zh_cn.json * Create zh_cn.json
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
* update ko_kr * fix typo
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents the 1.8.1 update for StarT Core. To contribute, open PRs to the develop branch.
Changelog (updated as we go):
Fixes: